Refactor Dockerfile by removing bun installation - #2491
Open
raphaelauv wants to merge 2 commits into
Open
raphaelauv wants to merge 2 commits into
raphaelauv wants to merge 2 commits into
Conversation
the build fail with ``` => [6/9] COPY frontend/package.json /app/frontend/ 0.0s => [7/9] WORKDIR /app/frontend 0.0s => ERROR [8/9] RUN bun install 0.2s ------ > [8/9] RUN bun install: 0.168 /bin/sh: 1: bun: not found ------ [+] build 0/1 ⠙ Image full-stack-fastapi-template-playwright Building 6.5s Dockerfile.playwright:20 ``` so let's use the official bun image
Create a symbolic link for bun as bunx in the Dockerfile.
|
sum now plz |
Author
|
hello @bankasimo-tech , what do you mean by 'sum now plz' ? |
Member
|
@raphaelauv, thanks for your interest! Before you open more PRs, please make sure you read our contribution guidelines: https://tiangolo.com/open-source/contributing/#start-with-a-discussion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the build fail with
so let's use the official bun image